From notifications-return-3287-archive-asf-public=cust-asf.ponee.io@commons.apache.org Sun Jan 14 12:17:57 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 16547180651 for ; Sun, 14 Jan 2018 12:17:57 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0615D160C43; Sun, 14 Jan 2018 11:17:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4476E160C1D for ; Sun, 14 Jan 2018 12:17:56 +0100 (CET) Received: (qmail 7859 invoked by uid 500); 14 Jan 2018 11:17:55 -0000 Mailing-List: contact notifications-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list notifications@commons.apache.org Received: (qmail 7850 invoked by uid 99); 14 Jan 2018 11:17:55 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Jan 2018 11:17:55 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 60E57E01EC; Sun, 14 Jan 2018 11:17:55 +0000 (UTC) From: dweiss To: notifications@commons.apache.org Reply-To: notifications@commons.apache.org References: In-Reply-To: Subject: [GitHub] commons-compress issue #60: Replace custom 'dummy' byte addition for the odd... Content-Type: text/plain Message-Id: <20180114111755.60E57E01EC@git1-us-west.apache.org> Date: Sun, 14 Jan 2018 11:17:55 +0000 (UTC) Github user dweiss commented on the issue: https://github.com/apache/commons-compress/pull/60 Also, to be honest -- this boundedinputstream has synchronized read methods and I've no idea why they're there. I don't think we have to create thread-safe streams here (is this a requirement anyhow?). This isn't included in the patch, but I'd drop synchronized from boundedinputstream entirely. ---