commons-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bodewig <...@git.apache.org>
Subject [GitHub] commons-compress issue #37: COMPRESS-410 - cherry picked to fix merging issu...
Date Wed, 05 Jul 2017 15:38:27 GMT
Github user bodewig commented on the issue:

    https://github.com/apache/commons-compress/pull/37
  
    Thanks a lot Simon,
    
    Please take a look at fde6670 - I've only performed some minor changes that I didn't feel
like hackling you for. Things that may be a tiny bit more than just cosmetics:
    
    * I'm not sure why you went for the literal string `UTF-8` rather than the constant and
`isUTF8` method in `ZipEncodingHelper`, I've changed that (kinda) back
    * I've removed the `assert` from `NioZipEncoding.encode`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message