Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0D180200CA4 for ; Wed, 7 Jun 2017 21:27:31 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0BB83160BD0; Wed, 7 Jun 2017 19:27:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 78BD6160BBF for ; Wed, 7 Jun 2017 21:27:30 +0200 (CEST) Received: (qmail 84135 invoked by uid 500); 7 Jun 2017 19:27:29 -0000 Mailing-List: contact notifications-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list notifications@commons.apache.org Received: (qmail 84125 invoked by uid 99); 7 Jun 2017 19:27:29 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Jun 2017 19:27:29 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E8214DFF16; Wed, 7 Jun 2017 19:27:28 +0000 (UTC) From: tharakadesilva To: notifications@commons.apache.org Reply-To: notifications@commons.apache.org Message-ID: Subject: [GitHub] commons-numbers pull request #6: NUMBERS-40 Content-Type: text/plain Date: Wed, 7 Jun 2017 19:27:28 +0000 (UTC) archived-at: Wed, 07 Jun 2017 19:27:31 -0000 GitHub user tharakadesilva opened a pull request: https://github.com/apache/commons-numbers/pull/6 NUMBERS-40 Modified "GammaException" to be a subclass of "ArithmeticException" instead of "IllegalArgumentException". Modified the test assertions to expect for "GammaException"s instead of "IllegalArgumentException"s. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tharakadesilva/commons-numbers desilva/develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-numbers/pull/6.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6 ---- commit 813c6707ea0d47c78fc25ca79f6df990e6b8bf67 Author: Tharaka De Silva Date: 2017-06-07T19:21:23Z modified GammaException to be a part of ArithmeticException instead of IllegalArgumentException commit aadb0f0962a76264c7d8607453f6495e432a89d5 Author: Tharaka De Silva Date: 2017-06-07T19:25:01Z modified the test assertions to assert for the GammaException ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---