commons-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tharakadesilva <...@git.apache.org>
Subject [GitHub] commons-numbers pull request #6: NUMBERS-40
Date Wed, 07 Jun 2017 19:27:28 GMT
GitHub user tharakadesilva opened a pull request:

    https://github.com/apache/commons-numbers/pull/6

    NUMBERS-40

    Modified "GammaException" to be a subclass of "ArithmeticException" instead of "IllegalArgumentException".
    Modified the test assertions to expect for "GammaException"s instead of "IllegalArgumentException"s.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tharakadesilva/commons-numbers desilva/develop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-numbers/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6
    
----
commit 813c6707ea0d47c78fc25ca79f6df990e6b8bf67
Author: Tharaka De Silva <tharaka.uo@gmail.com>
Date:   2017-06-07T19:21:23Z

    modified GammaException to be a part of ArithmeticException instead of IllegalArgumentException

commit aadb0f0962a76264c7d8607453f6495e432a89d5
Author: Tharaka De Silva <tharaka.uo@gmail.com>
Date:   2017-06-07T19:25:01Z

    modified the test assertions to assert for the GammaException

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message