commons-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sesuncedu <>
Subject [GitHub] commons-compress pull request #41: COMPRESS-407 - Just Warn
Date Fri, 23 Jun 2017 00:51:55 GMT
GitHub user sesuncedu opened a pull request:

    COMPRESS-407 - Just Warn

    Warn if an invalid record size is set. 
    I would not recommend using this approach.

You can merge this pull request into a Git repository by running:

    $ git pull COMPRESS-407-WARN

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #41
commit f0c21325faf6f613821a8b542c73ac380f0feb6a
Author: Simon Spero <>
Date:   2017-06-11T22:48:42Z

    COMPRESS-407 Validate Block and Record Sizes
    Require block size >=0 that is multiple of 512 bytes.
    Use block size of 512 if one is not given.
    Require record size of 512 bytes. Deprecate constructors taking recordSize as parameter
    Modify tests to check for enforcement of record size == 512
    Modify tests to check for correct overall length  for
    different block sizes including PAX default, USTAR default, and unspecified.
    Signed-off-by: Simon Spero <>
    (cherry picked from commit d754d89)
    Signed-off-by: Simon Spero <>

commit abab94288a8b8de05ecfade6517456a2c8dc6fb2
Author: Simon Spero <>
Date:   2017-06-23T00:35:13Z

    COMPRESS-407 Validate Block sizes. Detect invalid record sizes, but just log a  warning.
    Signed-off-by: Simon Spero <>


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message