commons-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sesuncedu <...@git.apache.org>
Subject [GitHub] commons-compress pull request #39: COMPRESS-413: Performance improvements fo...
Date Thu, 22 Jun 2017 17:40:47 GMT
GitHub user sesuncedu opened a pull request:

    https://github.com/apache/commons-compress/pull/39

    COMPRESS-413:  Performance improvements for Travis builds 

    Change travis configuration to
    - skip pre-build install (which runs the install goal).
    - remove after_success code.
    - use mvnw to use up-to-date version of maven.
    - run all goals/phases previously included in after_sucess phase, using -Ptravis-jacoco
profile if one exists.
      - clean
      - apache-rat:check
      - test
      - jacoco:report
      - coveralls:report
    
      - This will fail the build if any of the above goals fail. The goals that are most likely
to fail are: apache-rat:check and test. coveralls configuration is changed in pom to not fail
the build if the service is not available (e.g. for forks that do not have repository registered
with coveralls).
    
     -  Note that the apache-rat: check could be added to the pom (executing by default in
the validate phase)
     -  Also note that the jacoco:check goal can  be added to the pom (executing by default
in the verify phase).
     -  the script could then be changed to execute the verify goal.
     - coveralls stuff could be run in an after_success script. That script could restrict
coveralls notification to a single point in the jdk matrix


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sesuncedu/commons-compress COMPRESS-413

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-compress/pull/39.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #39
    
----
commit ed024e9a6de41f72655674f0c7cdcce5700cf82d
Author: Simon Spero <sesuncedu@gmail.com>
Date:   2017-06-19T20:15:16Z

    add mvnw
    
    (cherry picked from commit 91a08f4)
    Signed-off-by: Simon Spero <sesuncedu@gmail.com>

commit 8d543fd017f5c963f25541109fd48ceba1e0666c
Author: Simon Spero <sesuncedu@gmail.com>
Date:   2017-06-22T16:13:45Z

    COMPRESS-413
    Alter pom.xml:
    - Add Simon Spero as contributor.
    - change javadoc configuration to use <docencoding> (lowercase e) instead of <docEncoding>
(uppercase E).
      - see https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#docencoding
    - exclude .mvn/** from rat check (mvnw and mvnw.cmd are ok since they already have APL
header).
    - add plugin configuration for coveralls to pluginManagement. Set failOnServiceError to
false to avoid breaking the build
    if coveralls is not available
    
    Signed-off-by: Simon Spero <sesuncedu@gmail.com>

commit 95974fc671661244c83fdead2231f8367a67d2ba
Author: Simon Spero <sesuncedu@gmail.com>
Date:   2017-06-22T17:00:13Z

    COMPRESS-413
    Change travis configuration to
    - skip pre-build install (which runs the install goal).
    - remove after_success code.
    - use mvnw to use up-to-date version of maven.
    - run all goals/phases previously included in after_sucess phase, using -Ptravis-jacoco
profile if one exists.
      - clean
      - apache-rat:check
      - test
      - jacoco:report
      - coveralls:report
    
      - This will fail the build if any of the above goals fail. The goals that are most likely
to fail are: apache-rat:check and test. coveralls configuration is changed in pom to not fail
the build if the service is not available (e.g. for forks that do not have repository registered
with coveralls).
    
     -  Note that the apache-rat: check could be added to the pom (executing by default in
the validate phase)
     -  Also note that the jacoco:check goal can  be added to the pom (executing by default
in the verify phase).
     -  the script could then be changed to execute the verify goal.
     - coveralls stuff could run in a after_success script that checked and only ran for a
selected jdk
    
    Signed-off-by: Simon Spero <sesuncedu@gmail.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message