commons-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From RayDeCampo <...@git.apache.org>
Subject [GitHub] commons-numbers pull request #4: Create structure for fraction module within...
Date Mon, 23 Jan 2017 01:49:51 GMT
GitHub user RayDeCampo opened a pull request:

    https://github.com/apache/commons-numbers/pull/4

    Create structure for fraction module within commons-numbers.

    Add dependencyManagement to parent pom.xml for uniform dependency on numbers core; remove
version from references to numbers-core in child modules.
    Add test jar to numbers core pom.xml to allow for re-use of TestUtils.
    Add ArithmeticUtils from commons-math since Fraction, BigFraction heavily depends on it.
    
    I pulled the classes from the develop branch of commons-math.
    I had to do something with the exceptions, I created a handful but I think we will want
to revisit and perhaps make them more cohesive.
    As noted above I pulled in ArithmeticUtils from commons-math.
    I did not make a lot of changes to the comments, they probably need to be looked over.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/RayDeCampo/commons-numbers fractions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-numbers/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4
    
----
commit aaef6f7aa74da893b018ec3debe4367de3243c48
Author: Ray DeCampo <ray@decampo.org>
Date:   2017-01-23T01:41:30Z

    Create structure for fraction module within commons-numbers.
    Add dependencyManagement to parent pom.xml for uniform dependency on numbers core; remove
version from references to numbers-core in child modules.
    Add test jar to numbers core pom.xml to allow for re-use of TestUtils.
    Add ArithmeticUtils from commons-math since Fraction, BigFraction heavily depends on it.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message