commons-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From RayDeCampo <...@git.apache.org>
Subject [GitHub] commons-complex pull request #2: [COMPLEX-1] Testing fails due to poor null ...
Date Sun, 08 Jan 2017 00:56:40 GMT
GitHub user RayDeCampo opened a pull request:

    https://github.com/apache/commons-complex/pull/2

    [COMPLEX-1] Testing fails due to poor null handling in newly created local equals() and
equals-type methods

    Use Precision.equals() in TestUtils where appropriate.
    Use IllegalArgumentException in ComplexUtils instead of RuntimeException

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/RayDeCampo/commons-complex COMPLEX-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-complex/pull/2.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2
    
----
commit c11baf2d397134c700b17a1603b041d49e2af01e
Author: Ray DeCampo <ray@decampo.org>
Date:   2017-01-07T16:58:40Z

    [COMPLEX-1] Use Precision.equals() in TestUtils where appropriate.
    Use IllegalArgumentException in ComplexUtils instead of RuntimeException

commit 2926b81702424c6ed92b19959266e8bd72cb8991
Author: Ray DeCampo <ray@decampo.org>
Date:   2017-01-08T00:53:42Z

    Merge branch 'master' into COMPLEX-1

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message