From issues-return-92373-archive-asf-public=cust-asf.ponee.io@commons.apache.org Mon Sep 21 00:10:03 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 3835C18064E for ; Mon, 21 Sep 2020 02:10:03 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 6E81E122400 for ; Mon, 21 Sep 2020 00:10:02 +0000 (UTC) Received: (qmail 19528 invoked by uid 500); 21 Sep 2020 00:10:02 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 19513 invoked by uid 99); 21 Sep 2020 00:10:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Sep 2020 00:10:02 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E890D40C39 for ; Mon, 21 Sep 2020 00:10:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 113B07801FB for ; Mon, 21 Sep 2020 00:10:00 +0000 (UTC) Date: Mon, 21 Sep 2020 00:10:00 +0000 (UTC) From: "ASF GitHub Bot (Jira)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (IMAGING-265) ArrayIndexOutOfBoundsException on reading simple GeoTIFF MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IMAGING-265?focusedWorklogId= =3D486724&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-ta= bpanel#worklog-486724 ] ASF GitHub Bot logged work on IMAGING-265: ------------------------------------------ Author: ASF GitHub Bot Created on: 21/Sep/20 00:09 Start Date: 21/Sep/20 00:09 Worklog Time Spent: 10m=20 Work Description: gwlucastrig commented on a change in pull request #= 98: URL: https://github.com/apache/commons-imaging/pull/98#discussion_r49175197= 0 ########## File path: src/main/java/org/apache/commons/imaging/formats/tiff/datareader= s/DataReaderStrips.java ########## @@ -237,27 +240,51 @@ private void interpretStrip( =20 @Override public void readImageData(final ImageBuilder imageBuilder) - throws ImageReadException, IOException { - for (int strip =3D 0; strip < imageData.getImageDataLength(); stri= p++) { - final long rowsPerStripLong =3D 0xFFFFffffL & rowsPerStrip; - final long rowsRemaining =3D height - (strip * rowsPerStripLon= g); - final long rowsInThisStrip =3D Math.min(rowsRemaining, rowsPer= StripLong); - final long bytesPerRow =3D (bitsPerPixel * width + 7) / 8; - final long bytesPerStrip =3D rowsInThisStrip * bytesPerRow; - final long pixelsPerStrip =3D rowsInThisStrip * width; - - final byte[] compressed =3D imageData.getImageData(strip).getD= ata(); - - final byte[] decompressed =3D decompress(compressed, compressi= on, - (int) bytesPerStrip, width, (int) rowsInThisStrip); - - interpretStrip( - imageBuilder, - decompressed, - (int) pixelsPerStrip, - height); - + throws ImageReadException, IOException { + if (planarConfiguration !=3D 2) { Review comment: You are absolutely right about using the TiffTagConstant values in t= he places you cited. Actually, I wanted to make line 244 test for planarCo= nfiguration =3D=3D "Chunky" rather than !=3D "Planar", but I was afraid tha= t there might be places in the code where the planarConfiguration variable = didn't get set correctly. So I thought this would be safer. =20 If we ever get our hands on some additional test files, I might revisit = this. But that may be unlikely... The Tiff Specification itself describes= planar-configuration 2 as follows: _PlanarConfiguration=3D2 is not current= ly in widespread use and it is not recommended for general interchange. It = is used an extension and Baseline TIFF readers are not required to support = it._ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 486724) Time Spent: 1h 20m (was: 1h 10m) > ArrayIndexOutOfBoundsException on reading simple GeoTIFF > -------------------------------------------------------- > > Key: IMAGING-265 > URL: https://issues.apache.org/jira/browse/IMAGING-265 > Project: Commons Imaging > Issue Type: Bug > Components: Format: TIFF > Affects Versions: 1.0-alpha2 > Reporter: edgar soldin > Assignee: Bruno P. Kinoshita > Priority: Major > Attachments: small_world.tif, small_world_split.jpg > > Time Spent: 1h 20m > Remaining Estimate: 0h > > hi, > =C2=A0 > we on the OpenJUMP project cannot open some GeoTIFFs with commons.imaging= . for details you may find a ticket in our bug tracker [https://sourceforg= e.net/p/jump-pilot/bugs/498/]=C2=A0. > =C2=A0 > the gist is: on loading the attached file getBufferedImage() fails with t= his stack > Caused by: java.lang.ArrayIndexOutOfBoundsException: 8000Caused by: java.= lang.ArrayIndexOutOfBoundsException: 8000 at org.apache.commons.imaging.for= mats.tiff.datareaders.DataReaderStrips.interpretStrip(DataReaderStrips.java= :196) at org.apache.commons.imaging.formats.tiff.datareaders.DataReaderStri= ps.readImageData(DataReaderStrips.java:254) at org.apache.commons.imaging.f= ormats.tiff.TiffImageParser.getBufferedImage(TiffImageParser.java:665) at o= rg.apache.commons.imaging.formats.tiff.TiffDirectory.getTiffImage(TiffDirec= tory.java:254) at org.apache.commons.imaging.formats.tiff.TiffImageParser.g= etBufferedImage(TiffImageParser.java:469) at org.apache.commons.imaging.Ima= ging.getBufferedImage(Imaging.java:1442) at org.apache.commons.imaging.Imag= ing.getBufferedImage(Imaging.java:1335) at org.apache.commons.imaging.Imagi= ng.getBufferedImage(Imaging.java:1304) at com.vividsolutions.jump.workbench= .imagery.graphic.CommonsImage.initImage(CommonsImage.java:108) -- This message was sent by Atlassian Jira (v8.3.4#803005)