From issues-return-91994-archive-asf-public=cust-asf.ponee.io@commons.apache.org Thu Sep 3 18:15:26 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id B520D180636 for ; Thu, 3 Sep 2020 20:15:26 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id CC1B4121C6D for ; Thu, 3 Sep 2020 18:15:25 +0000 (UTC) Received: (qmail 55952 invoked by uid 500); 3 Sep 2020 18:15:25 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 55940 invoked by uid 99); 3 Sep 2020 18:15:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Sep 2020 18:15:25 +0000 From: =?utf-8?q?GitBox?= To: issues@commons.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bcommons-codec=5D_welcor_commented_on_a_change_in_p?= =?utf-8?q?ull_request_=2319=3A_CODEC-134=3A_Update_commons-codec_to_reject_?= =?utf-8?q?decoding_any_impossible_string_encoding_for_Base32_and_Base64=2E?= Message-ID: <159915692513.32230.4301915390269054374.asfpy@gitbox.apache.org> Date: Thu, 03 Sep 2020 18:15:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: welcor commented on a change in pull request #19: URL: https://github.com/apache/commons-codec/pull/19#discussion_r483167389 ########## File path: src/test/java/org/apache/commons/codec/binary/Base64TestData.java ########## @@ -30,7 +30,7 @@ */ public class Base64TestData { - public static final String CODEC_101_MULTIPLE_OF_3 = "123"; + public static final String CODEC_101_MULTIPLE_OF_3 = "124"; Review comment: I dug in and found the reason: https://issues.apache.org/jira/browse/CODEC-134?focusedCommentId=13222167&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13222167 It should really be renamed to "three digit valid base64 value" or someting. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org