commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-codec] aherbert commented on a change in pull request #19: CODEC-134: Update commons-codec to reject decoding any impossible string encoding for Base32 and Base64.
Date Thu, 03 Sep 2020 18:41:13 GMT

aherbert commented on a change in pull request #19:
URL: https://github.com/apache/commons-codec/pull/19#discussion_r483182397



##########
File path: src/test/java/org/apache/commons/codec/binary/Base64TestData.java
##########
@@ -30,7 +30,7 @@
  */
 public class Base64TestData {
 
-    public static final String CODEC_101_MULTIPLE_OF_3 = "123";
+    public static final String CODEC_101_MULTIPLE_OF_3 = "124";

Review comment:
       This variable dates back to an old bug for CODEC-101. The variable should have a byte
length that is a multiple of 3. The issue is that the string `123` is not a valid base 64
encoding, so it had to change for this PR. I suggest a name change to `CODEC_101_INPUT_LENGTH_IS_MULTIPLE_OF_3`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message