From issues-return-73954-archive-asf-public=cust-asf.ponee.io@commons.apache.org Thu May 2 14:44:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 570E318067E for ; Thu, 2 May 2019 16:44:02 +0200 (CEST) Received: (qmail 71571 invoked by uid 500); 2 May 2019 14:44:01 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 71558 invoked by uid 99); 2 May 2019 14:44:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 May 2019 14:44:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CE34BE2B6D for ; Thu, 2 May 2019 14:44:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 37C6625816 for ; Thu, 2 May 2019 14:44:00 +0000 (UTC) Date: Thu, 2 May 2019 14:44:00 +0000 (UTC) From: "Gilles (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEOMETRY-32) BSPTree Updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GEOMETRY-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831665#comment-16831665 ] Gilles commented on GEOMETRY-32: -------------------------------- bq. I'm wondering if this is still the best approach. Is there an alternative? > BSPTree Updates > --------------- > > Key: GEOMETRY-32 > URL: https://issues.apache.org/jira/browse/GEOMETRY-32 > Project: Apache Commons Geometry > Issue Type: Improvement > Components: core > Reporter: Matt Juntunen > Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > The following updates should be made to the BSPTree class: > - add an {{isLeaf()}} method to replace all of the {{node.getCut() == null}} expressions > - add unit tests > _Edit [2019-02-17]:_ > Additional goals: > - Refactor the API to split the idea of a general BSPTree and a BSPTree used for defining in/out regions. This could result in a BSPTree interface and a RegionBSPTree interface. The goal here is to allow end-users to create their own extensions of these classes and specialize them for their own applications (for example, to implement spatial sorting or other algorithms). This will be one of the only planned extension points in the library. > - Make the API easier to use and extend and reduce the necessity of casting (especially unchecked casting) as much as possible. > - Add the idea of convex subhyperplanes to allow for more efficient tree construction. -- This message was sent by Atlassian JIRA (v7.6.3#76005)