commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-bcel] garydgregory commented on a change in pull request #26: [BCEL-317] Pluggable cache for ConstantUtf8
Date Mon, 13 May 2019 14:31:35 GMT
garydgregory commented on a change in pull request #26: [BCEL-317] Pluggable cache for ConstantUtf8
URL: https://github.com/apache/commons-bcel/pull/26#discussion_r283375434
 
 

 ##########
 File path: src/main/java/org/apache/bcel/classfile/ConstantUtf8.java
 ##########
 @@ -88,39 +128,11 @@ public void run() {
         }
     }
 
-    /**
 
 Review comment:
   You cannot remove existing public methods. That causes a break in binary compatibility.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message