commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-net] fbrissi opened a new pull request #28: [NET-649] 227 Entering Passive Mode
Date Thu, 02 May 2019 13:54:12 GMT
fbrissi opened a new pull request #28: [NET-649] 227 Entering Passive Mode
URL: https://github.com/apache/commons-net/pull/28
 
 
   In a situation where I passed, the FTP server is restoring 227 Entering Passive Mode (0,0,0,0,156,126),
so it was obvious to me that the problem is on the server side and not on the API, but using
the File Zila client and analyze the log precebi that the same problem was also happening,
so he changed the route to use the IP of the server that returned this information and thus
manages to make the route correctly.
   
   So I made a similar implementation so that when the server returns IP 0,0,0,0 use the same
IP used to connect to the server. I'm not sure if it's necessary to validate anything beyond
"0,0,0,0" because it's the first time I see a situation like this, I'm not sure if the server
could return another invalid IP.
   
   I did not create a test for this case because I do not know how to force it to happen,
since it only occurred on a private server that I am using. This is a workaround I've solved,
and I'm helping to get you into future versions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message