From issues-return-73249-archive-asf-public=cust-asf.ponee.io@commons.apache.org Fri Apr 5 10:58:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B2EB918067E for ; Fri, 5 Apr 2019 12:58:02 +0200 (CEST) Received: (qmail 50520 invoked by uid 500); 5 Apr 2019 10:58:01 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 50509 invoked by uid 99); 5 Apr 2019 10:58:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Apr 2019 10:58:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 30A6AE29A7 for ; Fri, 5 Apr 2019 10:58:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 500282459D for ; Fri, 5 Apr 2019 10:58:00 +0000 (UTC) Date: Fri, 5 Apr 2019 10:58:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (LANG-1443) Add more SystemUtils.IS_JAVA_XX variants MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LANG-1443?focusedWorklogId=3D2= 23530&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpan= el#worklog-223530 ] ASF GitHub Bot logged work on LANG-1443: ---------------------------------------- Author: ASF GitHub Bot Created on: 05/Apr/19 10:57 Start Date: 05/Apr/19 10:57 Worklog Time Spent: 10m=20 Work Description: chtompki commented on pull request #415: LANG-1443:= Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415#discussion_r272538761 =20 =20 ########## File path: src/test/java/org/apache/commons/lang3/JavaVersionTest.java ########## @@ -20,23 +20,10 @@ =20 import org.junit.jupiter.api.Test; =20 -import static org.apache.commons.lang3.JavaVersion.JAVA_RECENT; +import static org.apache.commons.lang3.JavaVersion.*; =20 Review comment: IntelliJ does that by default at greater than 5 import statements. It re= writes them with the * =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 223530) Time Spent: 40m (was: 0.5h) > Add more SystemUtils.IS_JAVA_XX variants > ---------------------------------------- > > Key: LANG-1443 > URL: https://issues.apache.org/jira/browse/LANG-1443 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* > Reporter: Benedikt Ritter > Assignee: Benedikt Ritter > Priority: Major > Fix For: 3.9 > > Time Spent: 40m > Remaining Estimate: 0h > > We should add variants for SystemUtils.IS_JAVA_XX=C2=A0at least up until = the next EA release which at the time of this writing it Java 13. -- This message was sent by Atlassian JIRA (v7.6.3#76005)