From issues-return-73532-archive-asf-public=cust-asf.ponee.io@commons.apache.org Tue Apr 16 23:57:20 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 13DBF180630 for ; Wed, 17 Apr 2019 01:57:19 +0200 (CEST) Received: (qmail 79987 invoked by uid 500); 16 Apr 2019 23:57:19 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 79976 invoked by uid 99); 16 Apr 2019 23:57:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Apr 2019 23:57:19 +0000 From: GitBox To: issues@commons.apache.org Subject: [GitHub] [commons-lang] GedMarc edited a comment on issue #299: Add module-info for Java 9 Message-ID: <155545903419.15999.735275439520042890.gitbox@gitbox.apache.org> Date: Tue, 16 Apr 2019 23:57:14 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit GedMarc edited a comment on issue #299: Add module-info for Java 9 URL: https://github.com/apache/commons-lang/pull/299#issuecomment-483881536 @jodastephen @jfallows I have successfully managed to get moditect on lang3, io, fileupload and text - https://github.com/GedMarc/commons-lang https://github.com/GedMarc/commons-io https://github.com/GedMarc/commons-fileupload Using source and target of 1.6 is still supported to build for that target JDK (I have done this successfully with the org.json project), however the actual build has to happen in JDK 8 for the plugin to work. When building the module-info, no import statements are allowed as yet I place them directly in the root, @ClassGraph (Duke Choice Winner), places the module info files in the meta-inf/versions/ correctly with moditect. He also participates in the moditect development. https://github.com/GedMarc/commons-lang/blob/master/src/jre11/java/module-info.java https://github.com/GedMarc/commons-fileupload/blob/master/src/jre11/java/module-info.java ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services