commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Juntunen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (GEOMETRY-29) Plane API cleanup
Date Thu, 04 Apr 2019 00:19:00 GMT

     [ https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Matt Juntunen updated GEOMETRY-29:
----------------------------------
    Description: 
The following changes should be made to the {{o.a.c.g.euclidean.threed.Plane}} class:
 * make the class immutable
 * use well-named factory methods instead of constructor overloads
 * provide a factory method to create a plane with user-supplied {{u}} and {{v}} axes. The
current implementation allows the normal to be provided but chooses its own planar axes (see
{{setFrame}}).
 * add {{equals}}, {{hashCode}}, and {{toString}} methods.

  was:
The following changes should be made to the {{o.a.c.g.euclidean.threed.Plane}} class:
 * make the class immutable
 * use well-named factory methods instead of constructor overloads
 * provide a factory method to create a plane with user-supplied {{u}} and {{v}} axes. The
current implementation allows the normal to be provided but chooses its own planar axes (see
{{setFrame}}).
 * add {{equals}}, {{hashCode}}, and {{toString}} methods.

Pull request: https://github.com/apache/commons-geometry/pull/31


> Plane API cleanup
> -----------------
>
>                 Key: GEOMETRY-29
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-29
>             Project: Apache Commons Geometry
>          Issue Type: Improvement
>            Reporter: Matt Juntunen
>            Priority: Major
>
> The following changes should be made to the {{o.a.c.g.euclidean.threed.Plane}} class:
>  * make the class immutable
>  * use well-named factory methods instead of constructor overloads
>  * provide a factory method to create a plane with user-supplied {{u}} and {{v}} axes.
The current implementation allows the normal to be provided but chooses its own planar axes
(see {{setFrame}}).
>  * add {{equals}}, {{hashCode}}, and {{toString}} methods.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message