commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-vfs] garydgregory commented on a change in pull request #59: Add ability to specify buffer sizes
Date Wed, 24 Apr 2019 14:20:02 GMT
garydgregory commented on a change in pull request #59: Add ability to specify buffer sizes
URL: https://github.com/apache/commons-vfs/pull/59#discussion_r278150441
 
 

 ##########
 File path: commons-vfs2/src/main/java/org/apache/commons/vfs2/FileContent.java
 ##########
 @@ -147,6 +147,19 @@
      */
     InputStream getInputStream() throws FileSystemException;
 
+    /**
+     * Returns an input stream for reading the file's content.
+     * <p>
+     * There may only be a single input or output stream open for the file at any time.
+     *
+     * @param bufferSize The buffer size to use.
+     * @return An input stream to read the file's content from. The input stream is buffered,
so there is no need to
+     *         wrap it in a {@code BufferedInputStream}.
+     * @throws FileSystemException If the file does not exist, or is being read, or is being
written, or on error
+     *             opening the stream.
+     */
+    InputStream getInputStream(int bufferSize) throws FileSystemException;
+
 
 Review comment:
   > Or call the original method by just ignoring the argument?
   
   IMO, yes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message