commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-geometry] darkma773r commented on a change in pull request #31: Geometry 29 2 sven
Date Wed, 03 Apr 2019 01:02:45 GMT
darkma773r commented on a change in pull request #31: Geometry 29 2 sven
URL: https://github.com/apache/commons-geometry/pull/31#discussion_r271548380
 
 

 ##########
 File path: commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Line.java
 ##########
 @@ -236,5 +238,29 @@ public Vector3D intersection(final Line line) {
     public SubLine wholeLine() {
         return new SubLine(this, new IntervalsSet(precision));
     }
+    
+    
 
+    @Override
+    public int hashCode() {
+        throw new IllegalStateException("Must not be used in maps.");
 
 Review comment:
   We should provide an actual implementation of this method, especially since `equals()`
is overridden.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message