From issues-return-72225-archive-asf-public=cust-asf.ponee.io@commons.apache.org Sun Mar 3 22:34:12 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DC142180630 for ; Sun, 3 Mar 2019 23:34:11 +0100 (CET) Received: (qmail 25837 invoked by uid 500); 3 Mar 2019 22:34:11 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 25826 invoked by uid 99); 3 Mar 2019 22:34:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Mar 2019 22:34:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 68398C2113 for ; Sun, 3 Mar 2019 22:34:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id QMdTUMlOlBuJ for ; Sun, 3 Mar 2019 22:34:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9AC845F544 for ; Sun, 3 Mar 2019 22:28:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BACCCE01AC for ; Sun, 3 Mar 2019 22:28:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3F83E2570A for ; Sun, 3 Mar 2019 22:28:00 +0000 (UTC) Date: Sun, 3 Mar 2019 22:28:00 +0000 (UTC) From: "Alex D Herbert (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (RNG-78) ThreadLocalRandomSource MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/RNG-78?page=3Dcom.atlassian.jir= a.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16782890= #comment-16782890 ]=20 Alex D Herbert commented on RNG-78: ----------------------------------- Updated the benchmark to add a raw implementation using {{ThreadLocal}}. This shows how the factory method compares with a cust= om implementation: ||numValues||randomSourceName||Method||Score||Relative|| |0|N/A|threadLocalRandom|2.72|1.00| |0|N/A|threadLocalRandomWrapped|2.7|0.99| |0|SPLIT_MIX_64|randomSourceCreate|880.00|196.87| |0|SPLIT_MIX_64|threadLocalRandomSourceCurrent|6.26|1.40| |0|SPLIT_MIX_64|threadLocalUniformRandomProvider|4.88|1.79| |1|N/A|threadLocalRandom|4.47|1.64| |1|N/A|threadLocalRandomWrapped|4.45|1.64| |1|SPLIT_MIX_64|randomSourceCreate|780.00|286.76| |1|SPLIT_MIX_64|threadLocalRandomSourceCurrent|8.83|3.25| |1|SPLIT_MIX_64|threadLocalUniformRandomProvider|7.88|2.90| |10|N/A|threadLocalRandom|18.3|1.00| |10|N/A|threadLocalRandomWrapped|21.4|1.17| |10|SPLIT_MIX_64|randomSourceCreate|835.00|45.63| |10|SPLIT_MIX_64|threadLocalRandomSourceCurrent|28.50|1.56| |10|SPLIT_MIX_64|threadLocalUniformRandomProvider|27.90|1.52| |100|N/A|threadLocalRandom|154|1.00| |100|N/A|threadLocalRandomWrapped|196|1.27| |100|SPLIT_MIX_64|randomSourceCreate|807.00|5.24| |100|SPLIT_MIX_64|threadLocalRandomSourceCurrent|162.00|1.05| |100|SPLIT_MIX_64|threadLocalUniformRandomProvider|159.00|1.03| So using the factory method to get a RNG and generate 1 value is only margi= nally slower than using a custom ThreadLocal. This s= hows that the utility class is providing almost optimal performance and avo= ids an end user having to write this boiler plate code for any {{RandomSour= ce}} they would like to use. =C2=A0 > ThreadLocalRandomSource > ----------------------- > > Key: RNG-78 > URL: https://issues.apache.org/jira/browse/RNG-78 > Project: Commons RNG > Issue Type: New Feature > Components: simple > Affects Versions: 1.3 > Reporter: Alex D Herbert > Assignee: Alex D Herbert > Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > Implement a helper class that can provide thread-local {{UniformRandomPro= vider}} instances.=C2=A0 > This can be used as an equivalent of {{ThreadLocalRandom}}: > {code:java} > // c.f. > Random random =3D ThreadLocalRandom.current(); > // Access a thread-safe random number generator > UniformRandomProvider rng =3D=20 > ThreadLocalRandomSource.current(RandomSource.SPLIT_MIX_64); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)