From issues-return-72818-archive-asf-public=cust-asf.ponee.io@commons.apache.org Sun Mar 24 14:27:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C1D5818075F for ; Sun, 24 Mar 2019 15:27:02 +0100 (CET) Received: (qmail 43359 invoked by uid 500); 24 Mar 2019 14:27:01 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 43340 invoked by uid 99); 24 Mar 2019 14:27:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Mar 2019 14:27:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0574EE2839 for ; Sun, 24 Mar 2019 14:27:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5CC102459F for ; Sun, 24 Mar 2019 14:27:00 +0000 (UTC) Date: Sun, 24 Mar 2019 14:27:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (TEXT-126) Dice's Coefficient Algorithm in String similarity MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEXT-126?focusedWorklogId=3D21= 7715&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpane= l#worklog-217715 ] ASF GitHub Bot logged work on TEXT-126: --------------------------------------- Author: ASF GitHub Bot Created on: 24/Mar/19 14:26 Start Date: 24/Mar/19 14:26 Worklog Time Spent: 10m=20 Work Description: aherbert commented on pull request #103: TEXT-126: = Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r268436278 =20 =20 ########## File path: src/main/java/org/apache/commons/text/similarity/SorensenDiceSi= milarity.java ########## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied= . + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.similarity; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.List; +import java.util.function.Function; + +import org.apache.commons.lang3.StringUtils; + +/** + * A similarity algorithm indicating the percentage of matched characters + * between two character sequences. + * + *

+ * The Sørensen-Dice coefficient is a statistic used for comparing th= e + * similarity of two samples. It was independently developed by the botani= sts + * Thorvald Sørensen and Lee Raymond Dice, who published in 1948 and = 1945 + * respectively. The index is known by several other names, especially + * Sørensen-Dice index, Sørensen index and Dice's coefficient. O= ther + * variations include the "similarity coefficient" or "index", such as Dic= e + * similarity coefficient (DSC). + *

+ * + *

+ * This implementation is based on the Sørensen-Dice similarity algor= ithm + * from + * http://en.wikipedia.org/wiki/S%C3%B8rensen%E2%80%93Dice_coefficient= . + * + * + *

+ * + * @since 1.7 + */ +public class SorensenDiceSimilarity implements SimilarityScore { + + /** + * For shifting bigrams to fit in single integer. + */ + private static final int SHIFT_NUMBER =3D 16; =20 Review comment: Not part of this class but the internal converter class. =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 217715) Time Spent: 14.5h (was: 14h 20m) > Dice's Coefficient Algorithm in String similarity > ------------------------------------------------- > > Key: TEXT-126 > URL: https://issues.apache.org/jira/browse/TEXT-126 > Project: Commons Text > Issue Type: Improvement > Reporter: Vicky Chawda > Priority: Major > Time Spent: 14.5h > Remaining Estimate: 0h > > I'd like to propose an extension to the algorithms for string similarity = in=C2=A0*commons-text/src/main/java/org/apache/commons/text/similarity/* > =C2=A0Dice's Coefficient Algorithm can be helpful for many who are lookin= g for ranking similarities in strings. > *Inspired from* - [http://www.catalysoft.com/articles/StrikeAMatch.html] -- This message was sent by Atlassian JIRA (v7.6.3#76005)