From issues-return-72174-archive-asf-public=cust-asf.ponee.io@commons.apache.org Sun Mar 3 11:32:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EFB3E180630 for ; Sun, 3 Mar 2019 12:32:05 +0100 (CET) Received: (qmail 7656 invoked by uid 500); 3 Mar 2019 11:32:05 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 7645 invoked by uid 99); 3 Mar 2019 11:32:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Mar 2019 11:32:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6C23EC0060 for ; Sun, 3 Mar 2019 11:32:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id YPlPF8zhtBuF for ; Sun, 3 Mar 2019 11:32:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 289415F6C7 for ; Sun, 3 Mar 2019 11:32:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DE646E2765 for ; Sun, 3 Mar 2019 11:32:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3046125702 for ; Sun, 3 Mar 2019 11:32:00 +0000 (UTC) Date: Sun, 3 Mar 2019 11:32:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (TEXT-111) WordUtils.wrap must calculate offset increment from wrapOn pattern length MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEXT-111?focusedWorklogId=206888&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-206888 ] ASF GitHub Bot logged work on TEXT-111: --------------------------------------- Author: ASF GitHub Bot Created on: 03/Mar/19 11:31 Start Date: 03/Mar/19 11:31 Worklog Time Spent: 10m Work Description: kinow commented on issue #104: TEXT-111 URL: https://github.com/apache/commons-text/pull/104#issuecomment-469013944 Merged. Thanks @CAPS50 ! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 206888) Time Spent: 0.5h (was: 20m) > WordUtils.wrap must calculate offset increment from wrapOn pattern length > ------------------------------------------------------------------------- > > Key: TEXT-111 > URL: https://issues.apache.org/jira/browse/TEXT-111 > Project: Commons Text > Issue Type: Bug > Affects Versions: 1.2 > Reporter: Michael Keppler > Assignee: Bruno P. Kinoshita > Priority: Major > Fix For: 1.7 > > Time Spent: 0.5h > Remaining Estimate: 0h > > WordUtils.wrap(...) allows to specify the "wrapOn" regular expression to be used as breakable characters. If this pattern is a zero width assertion or is longer than 1 charachter, then the output is wrong because the wrapping algorithm always skips one character (assuming the line break character has a width of 1). > Example failing test: > {code:java} > assertThat(WordUtils.wrap("abcdef", 2, "\n", false, "(?=d)")).isEqualTo("abc\ndef"); > // produces "abc\nef" instead > {code} > Fix would be to change the 2 occurences of > {code:java} > offset = spaceToWrapAt + 1; > {code} > to > {code:java} > offset = spaceToWrapAt + matcher.end() - matcher.start(); > {code} > thereby not advancing 1 character each time, but as many characters as were just matched. -- This message was sent by Atlassian JIRA (v7.6.3#76005)