commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (FILEUPLOAD-296) Speed Up Parsing
Date Mon, 18 Mar 2019 09:54:00 GMT

     [ https://issues.apache.org/jira/browse/FILEUPLOAD-296?focusedWorklogId=214660&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214660
]

ASF GitHub Bot logged work on FILEUPLOAD-296:
---------------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Mar/19 09:53
            Start Date: 18/Mar/19 09:53
    Worklog Time Spent: 10m 
      Work Description: DaGeRe commented on pull request #18: (FILEUPLOAD-296) Reuse Buffer:
Using the same buffer speeds up the parsing process by …
URL: https://github.com/apache/commons-fileupload/pull/18
 
 
   …about 10% (Part-Revert 4ed6e923cb2033272fcb993978d69e325990a5aa)
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 214660)
            Time Spent: 10m
    Remaining Estimate: 0h

> Speed Up Parsing
> ----------------
>
>                 Key: FILEUPLOAD-296
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-296
>             Project: Commons FileUpload
>          Issue Type: Bug
>    Affects Versions: Nightly Builds, 2.x
>            Reporter: David Georg Reichelt
>            Priority: Minor
>              Labels: perfomance, pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In 4ed6e923cb2033272fcb993978d69e325990a5aa, FileUploadBase.parseRequest was changed:
Instead of using a buffer declared there and passing it to Streams.copy(InputStream, OutputStream
, boolean, byte[]), Streams.copy(InputStream, OutputStream , boolean) was used.
> This slows down the parsing by ~ 10%: Since in every iteration of the loop a new buffer
is created in Streams.copy, additional effort is created. I therefore recommend to create
a buffer and reuse it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message