commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (LANG-1437) Remove redundant if statements in StringUtils.join
Date Mon, 04 Mar 2019 21:16:00 GMT

     [ https://issues.apache.org/jira/browse/LANG-1437?focusedWorklogId=207433&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207433
]

ASF GitHub Bot logged work on LANG-1437:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Mar/19 21:15
            Start Date: 04/Mar/19 21:15
    Worklog Time Spent: 10m 
      Work Description: aft90 commented on pull request #411: LANG-1437: Remove redundant
if statements in join methods
URL: https://github.com/apache/commons-lang/pull/411
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 207433)
            Time Spent: 10m
    Remaining Estimate: 0h

> Remove redundant if statements in StringUtils.join
> --------------------------------------------------
>
>                 Key: LANG-1437
>                 URL: https://issues.apache.org/jira/browse/LANG-1437
>             Project: Commons Lang
>          Issue Type: Improvement
>            Reporter: Andrei Filip Troie
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In the various {{join}} methods in {{StringUtils}}, the for-loop contains an {{if (i
> startIndex)}} (for an example see [here|https://github.com/apache/commons-lang/blob/eb5b11a25c9e61f9b25a540682816ebb103b735c/src/main/java/org/apache/commons/lang3/StringUtils.java#L4203],
but it's present in all the {{join}} methods that take an array). That is unnecessary - for
the first iteration, we know the condition is false, while for the other iterations, we know
the condition is true. So instead, we can do this:
>  * append the first element (at position {{startIndex}})
>  * for every other element (starting at position {{startIndex + 1}}), append the separator,
then the element.
> It's basically the same tactic used in the {{Iterable}} version.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message