commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (TEXT-151) JaroWinklerSimilarity uses Object.equals to test for equality
Date Sat, 02 Mar 2019 21:40:00 GMT

     [ https://issues.apache.org/jira/browse/TEXT-151?focusedWorklogId=206797&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-206797
]

ASF GitHub Bot logged work on TEXT-151:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Mar/19 21:39
            Start Date: 02/Mar/19 21:39
    Worklog Time Spent: 10m 
      Work Description: chtompki commented on issue #105: TEXT-151: Use StringUtils.equals
to test for CharSequence equality.
URL: https://github.com/apache/commons-text/pull/105#issuecomment-468962820
 
 
   LGTM
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 206797)
    Time Spent: 0.5h  (was: 20m)

> JaroWinklerSimilarity uses Object.equals to test for equality
> -------------------------------------------------------------
>
>                 Key: TEXT-151
>                 URL: https://issues.apache.org/jira/browse/TEXT-151
>             Project: Commons Text
>          Issue Type: Bug
>    Affects Versions: 1.7
>            Reporter: Alex D Herbert
>            Priority: Trivial
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Using Object.equals to test for equality of a {{CharSequence}} is wrong:
> {code:java}
> CharSequence cs1, cs2;
> cs1.equals(cs2);
> {code}
> The Unit test passes because the test uses the same String on both sides. When I changed
the unit test to wrap the string with a {{CharSequence}} interface it fails.
> It should be replaced with:
> {code:java}
> CharSequence cs1, cs2;
> StringUtils.equals(cs1, cs2);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message