commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-rng] aherbert commented on issue #32: Jdk 11 build
Date Fri, 29 Mar 2019 07:28:02 GMT
aherbert commented on issue #32: Jdk 11 build
URL: https://github.com/apache/commons-rng/pull/32#issuecomment-477897201
 
 
   Note:
   
   Javadoc generation does not work on JDK 11.0.2 due to the packages in the unamed module
error. A fix for this is present in JDK 11.0.3 (See [JDK-8212233](https://bugs.openjdk.java.net/browse/JDK-8212233)).

   
   I tried upgrading the pom to allow javadoc generation using JDK 11 using an explicit source/release
of 11. This required (note the javadoc-plugin fix above was incorrect:
   
   ```
       <!-- Java language level. -->
       <maven.compiler.source>11</maven.compiler.source>
       <maven.compiler.target>11</maven.compiler.target>
       <animal.sniffer.skip>true</animal.sniffer.skip>
       <maven.compiler.release>11</maven.compiler.release>
     </properties>
   
     <plugin>
       <artifactId>maven-javadoc-plugin</artifactId>
       <configuration>
         <!-- Reset API links since these refer to java 1.6 and 1.7 -->
         <links combine.self="override" />
       </configuration>
     </plugin>
   
   <!-- upgrade for java 11 -->
   maven-compiler-plugin -> 3.8.0
   maven-surefire-plugin -> 3.0.0-M3
   maven-surefire-report-plugin -> 3.0.0-M3
   ```
   
   Then the the site plugin fails on `default-site` goal:
   
   ```
   [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.7.1:site
   (default-site) on project commons-rng-examples-jpms-lib: Execution default-site of
   goal org.apache.maven.plugins:maven-site-plugin:3.7.1:site failed:
   org.apache.maven.reporting.MavenReportException: Unsupported targetJdk value '11'.
   ```
   
   Currently it seems that the maven plugins have yet to catch up to java 11. The solution
is to fix the main build command for java 11 and stick to supporting the full build with the
examples modules on JDK 9.
   
   This works.
   
   JDK 11
   
   `mvn clean package -P commons-rng-examples`
   
   JDK 9
   
   `mvn clean package site site:stage -P commons-rng-examples`
   
   JDK 8
   
   `mvn clean package site site:stage`
   
   This can be revisited when JDK 11.0.3 is released (if ever) and the Maven plugins catch
up to Java 11.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message