commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-text] kinow commented on issue #103: TEXT-126: Adding Sorensen-Dice similarity algoritham
Date Sun, 10 Mar 2019 04:47:01 GMT
kinow commented on issue #103: TEXT-126: Adding Sorensen-Dice similarity algoritham
URL: https://github.com/apache/commons-text/pull/103#issuecomment-471246910
 
 
   Good summary @aherbert , thanks a lot for that.
   
   My brain is still digesting it, and I won't risk commenting here on Sunday ~evening. Will
sleep on it, and probably work on a few other things next week (might be a bit busier at $work
too).
   
   Let's see if we can find one or two possible alternatives, and if we can't find a solution
that looks really good, we can take it to the dev mailing list to see what others think too.
   
   @ameyjadiye thanks for your patience so far. The work on #109 is really nice indeed! I
was going to merge it now but there are two pending checkstyle issues. Once fixed, I believe
they will be merged. Then if you could update this branch with that code, that would make
three of us who have looked over the API (so some good code review). Any feedback welcome,
as we have time to fix anything before 1.7.
   
   Cheers
   Bruno

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message