commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-text] kinow commented on issue #109: TEXT-155: Add a generic IntersectionSimilarity measure
Date Thu, 07 Mar 2019 23:12:12 GMT
kinow commented on issue #109: TEXT-155: Add a generic IntersectionSimilarity measure
URL: https://github.com/apache/commons-text/pull/109#issuecomment-470739020
 
 
   >This class could be used internally by the JaccardSimilarity. It could also be used
by a new Sorenson-Dice Similarity (although I prefer F1Score). 
   
   +1
   
   >Note: that new implementation for the Sorenson-Dice Similarity uses bigrams and not
single characters.
   
   Oh, good point. In that case I think I now understand your remark to maybe rename that
implementation in the pull request to something like BigramSorensonDice. Good food for thought,
no idea what's the best right now, but will think about it for a little while.
   
   >But I do not see why it should be package private. 
   
   Good arguments @aherbert . Then maybe leave it public, and move the F1/jaccard to the related
classes. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message