commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruno P. Kinoshita (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEXT-149) StringEscapeUtils.unescapeCsv doesn't remove quotes at begin and end of string
Date Thu, 13 Dec 2018 20:59:00 GMT

    [ https://issues.apache.org/jira/browse/TEXT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720602#comment-16720602
] 

Bruno P. Kinoshita commented on TEXT-149:
-----------------------------------------

[~kasopey] the URL you are using in your repository (i.e. [https://github.com/apache/commons-text/)]
is for the commons-text under the apache GitHub organisation. You do not have access to write
to this repository - that repository is actually a mirror of a git repository hosted by ASF
Infra, so I also do not have write access there.

Your work flow was almost correct. First you have to fork the repository under your GitHub
user. That will create a copy of commons-text in your repository. I did that too to send pull
requests, [https://github.com/kinow/commons-text.]

After you have forked it, you should be able to create a branch and push to that repository.
Alas there are multiple ways to use git, and each developer has a preferred set of commands,
some prefer the command line, others GUI. And troubleshooting git in this ticket could digress
too much from the main issue. If you have time, I think the best would be to have a read at
some of git's basic documentation
 * [https://guides.github.com/activities/forking/]
 * [http://swcarpentry.github.io/git-novice/]
 * [https://wiki.apache.org/commons/UsingGIT]

Once you have your work done in your branch, send the pull request. One of the committers
of the project will review, and either ask for feedback, or merge it. Please be patient as
the project is maintained by volunteers, so it may have some delay between iterations. Especially
given that we are so close to holidays, end of financial year in some country, etc.

And big thank you for your contribution

Bruno

> StringEscapeUtils.unescapeCsv doesn't remove quotes at begin and end of string
> ------------------------------------------------------------------------------
>
>                 Key: TEXT-149
>                 URL: https://issues.apache.org/jira/browse/TEXT-149
>             Project: Commons Text
>          Issue Type: Bug
>    Affects Versions: 1.6
>            Reporter: Krzysztof Szalast
>            Priority: Major
>
> org.apache.commons.text.translate.CsvTranslators:
> {code:java}
> void translateWhole(CharSequence input, Writer out) throws IOException {
>     if (input.charAt(0) == '"' && input.charAt(input.length() - 1) == '"')
{
>         String quoteless = input.subSequence(1, input.length() - 1).toString();
>         if (StringUtils.containsAny(quoteless, CsvTranslators.CSV_SEARCH_CHARS))
{
>             out.write(StringUtils.replace(quoteless, CsvTranslators.CSV_ESCAPED_QUOTE_STR,
CsvTranslators.CSV_QUOTE_STR));
>         } else {
>             out.write(input.toString());
>         }
>     } else {
>         out.write(input.toString());
>     }
> }{code}
>  
> In my opinion first occurence "out.write(input.toString());" should be replaced with:
> {code:java}
> out.write(quoteless.toString());{code}
> Because '"' quotes around "input" will be never removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message