commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <>
Subject [jira] [Commented] (GEOMETRY-11) Replace tolerance with GeometryContext
Date Fri, 21 Dec 2018 14:36:00 GMT


Gilles commented on GEOMETRY-11:

bq. name could be something like DoublePrecision

I didn't read the reference yet (sorry!) but it looks odd to have both {{Precision}} and {{DoublePrecision}}
side-by-side whereas the former contains functions that check equality of "double-precision"

> Replace tolerance with GeometryContext
> --------------------------------------
>                 Key: GEOMETRY-11
>                 URL:
>             Project: Apache Commons Geometry
>          Issue Type: Wish
>            Reporter: Matt Juntunen
>            Priority: Major
>             Fix For: 1.0
> All of the partitioning-related concrete classes (ex: Plane, PolygonsSet, PolyhedronsSet,
etc) use a double value named tolerance in order to address issues with floating point accuracy.
For example, when determining if a point lies in a plane, the point does not need to lie exactly
on the plane but just be within +- tolerance distance from it. Code testing values against
each other using this toleranceĀ isĀ repeated throughout the code base (ex: x >= y - tolerance).
We should abstract the concept of the tolerance into a GeometryContext class and provide methods
for testing values against each other using the tolerance. This will reduce the chance of
bugs and will also allow for more sophisticated handling of floating point accuracy later
> The GeometryContext class would be similar to the MathContext class used by BigDecimal
but would contain the logic for making comparisons in addition to the configuration for the
> {code:java}
> public class GeometryContext {
>    public GeometryContext(tolerance){...}
>    public double getTolerance(){ ... }
>    // return -1, 0, +1
>    public int compare(double a, double b) { ... }
> }{code}

This message was sent by Atlassian JIRA

View raw message