commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests
Date Wed, 19 Dec 2018 23:19:03 GMT
rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local
int variable and add more tests
URL: https://github.com/apache/commons-lang/pull/392#discussion_r243110330
 
 

 ##########
 File path: src/main/java/org/apache/commons/lang3/StringUtils.java
 ##########
 @@ -338,15 +338,17 @@ public static boolean isAllEmpty(final CharSequence... css) {
      * @since 3.0 Changed signature from isBlank(String) to isBlank(CharSequence)
      */
     public static boolean isBlank(final CharSequence cs) {
-        int strLen;
 
 Review comment:
   Or `idx`? But aren't we spend too much time for a discussion of one variable name? :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message