commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] MarkDacek commented on issue #391: Adding junits for JsonToStringStyle
Date Mon, 17 Dec 2018 21:24:38 GMT
MarkDacek commented on issue #391: Adding junits for JsonToStringStyle
URL: https://github.com/apache/commons-lang/pull/391#issuecomment-448004147
 
 
   Can you make your arrays in the new test cases final? Also perhaps avoid using the **new**
keyword when you don't need memory allocated at that exact moment. 
   
   Paging @chtompki for context. Should the JSON blurbs that are the expected output be final
Strings as well? That's not the existing pattern, but it seems a bit odd to be concatenating
to make deterministic Strings during an assert. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message