From issues-return-70550-archive-asf-public=cust-asf.ponee.io@commons.apache.org Wed Nov 7 14:00:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id CA85D18067E for ; Wed, 7 Nov 2018 14:00:06 +0100 (CET) Received: (qmail 92903 invoked by uid 500); 7 Nov 2018 13:00:05 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 92631 invoked by uid 99); 7 Nov 2018 13:00:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Nov 2018 13:00:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 30785C1BAF for ; Wed, 7 Nov 2018 13:00:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id qZQD0HgJtA_A for ; Wed, 7 Nov 2018 13:00:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 410A75F535 for ; Wed, 7 Nov 2018 13:00:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B9902E0F4C for ; Wed, 7 Nov 2018 13:00:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D74C8266BA for ; Wed, 7 Nov 2018 13:00:00 +0000 (UTC) Date: Wed, 7 Nov 2018 13:00:00 +0000 (UTC) From: "Gilles (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEOMETRY-23) Remove Euclidean Point Classes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GEOMETRY-23?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D166= 78197#comment-16678197 ]=20 Gilles commented on GEOMETRY-23: -------------------------------- OK. Let's assume that within this library, the term "vector" means "Cartesian"= . Then please * remove the {{ofSpherical}} and {{toSpherical}} methods in order to remov= e the circular dependency between {{Vector3D}} and {{SphericalCoordinates}}= (since {{Vector3D}} is the low-level object, conversion to and from it sho= uld be handled in the higher-level object), * ditto for the {{ofPolar}} and {{toPolar}} in {{Vector2D}}, * rename {{ofArray}} to {{of}}. Side note: The RAT report signals license non-compliances in module {{commo= ns-geometry-euclidean}} in the "test" area (python code). Could you please = look whether a header can be added; if not, the files should be removed fro= m the RAT check in the POM file. Thanks. > Remove Euclidean Point Classes > ------------------------------ > > Key: GEOMETRY-23 > URL: https://issues.apache.org/jira/browse/GEOMETRY-23 > Project: Apache Commons Geometry > Issue Type: Improvement > Reporter: Matt Juntunen > Priority: Major > Labels: pull-request-available > > Based on discussion of the current Point/Vector API in GEOMETRY-14 and re= search into other geometric libraries, I think we should remove the Euclide= an Point?D classes and make Vector?D also implement Point. This will end up= being similar to the previous commons-math design but avoids the issue rai= sed in MATH-1284 since the Point and Vector interfaces are not related. The= y just happen to be implemented by the same class, which we're calling Vect= or?D since a vector can be used to indicate a point (by adding it to the or= igin). > In the course of trying this out this design, I ended up removing 7 class= es and simplifying several methods. I think that's a good indicator that th= is is a good design choice. > =C2=A0 > Pull request: https://github.com/apache/commons-geometry/pull/15 -- This message was sent by Atlassian JIRA (v7.6.3#76005)