commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shukant Kumar Pal (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (IMAGING-218) PNG package code bloated
Date Tue, 27 Nov 2018 09:55:00 GMT

     [ https://issues.apache.org/jira/browse/IMAGING-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Shukant Kumar Pal updated IMAGING-218:
--------------------------------------
    Description: 
The PNG component is really really bloated, and code is written for the same thing twice sometimes.
For example, the formats.png package uses the `PngWriter` class which internally replicates
the features that should actually be contained within formats.png.chunk Chunk classes (like
PngWriter.ImageHeader which is just a PNG chunk representation, and can be eliminated by modified
Chunk and PngChunkIhdr).

The file format classes can be modified to reduce the code size significantly and make it
much more clear. I'll clean up the PNG code, but want the interest of the project members.

  was:
The formats.png package uses the PngWriter class which internally replicates the features
that should actually be contained within formats.png.chunk Chunk classes (like PngWriter.ImageHeader
which is just a PNG chunk representation, and can be eliminated by modified Chunk and PngChunkIhdr).

 

I'll clean up the PNG code, but want the interest of the project members.


> PNG package code bloated
> ------------------------
>
>                 Key: IMAGING-218
>                 URL: https://issues.apache.org/jira/browse/IMAGING-218
>             Project: Commons Imaging
>          Issue Type: Bug
>          Components: Format: PNG
>    Affects Versions: 1.x
>            Reporter: Shukant Kumar Pal
>            Priority: Major
>             Fix For: 1.x
>
>
> The PNG component is really really bloated, and code is written for the same thing twice
sometimes. For example, the formats.png package uses the `PngWriter` class which internally
replicates the features that should actually be contained within formats.png.chunk Chunk classes
(like PngWriter.ImageHeader which is just a PNG chunk representation, and can be eliminated
by modified Chunk and PngChunkIhdr).
> The file format classes can be modified to reduce the code size significantly and make
it much more clear. I'll clean up the PNG code, but want the interest of the project members.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message