commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shuai Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CONFIGURATION-731) Allow user to specify the comments & separator chars
Date Mon, 19 Nov 2018 02:53:00 GMT

    [ https://issues.apache.org/jira/browse/CONFIGURATION-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691199#comment-16691199
] 

Shuai Zhang commented on CONFIGURATION-731:
-------------------------------------------

[~garydgregory] Good point! I submitted new patch for it.

BTW, I've got a few questions:
 # Is there any tool help check Java binary compatibility? It's quite helpful to keep it for
providing a patched version of existing JAR.
 # Is there suggested way to provide a patch? I made it through both patch file here &
git PR [https://github.com/apache/commons-configuration/pull/16]
 # It seems that the Github repository didn't fully syncronized with our SVN repo?

> Allow user to specify the comments & separator chars
> ----------------------------------------------------
>
>                 Key: CONFIGURATION-731
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-731
>             Project: Commons Configuration
>          Issue Type: Improvement
>          Components: Format
>    Affects Versions: 2.4
>            Reporter: Shuai Zhang
>            Priority: Major
>         Attachments: CONFIGURATION-731.001.patch, CONFIGURATION-731.002.patch
>
>
> Currently the INIConfiguration defined comments & separator chars as final static
fields, which made it impossible for the user control the behavior of INIConfiguration parsing.
I suggest making them as default value, open setter & getter methods for the comment &
separator chars.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message