commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEXT-138) TextStringBuilder append sub-sequence not consistent with Appendable
Date Thu, 08 Nov 2018 16:12:00 GMT

    [ https://issues.apache.org/jira/browse/TEXT-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679954#comment-16679954
] 

ASF GitHub Bot commented on TEXT-138:
-------------------------------------

Github user drajakumar commented on the issue:

    https://github.com/apache/commons-text/pull/92
  
    closing as its consider in this commit https://github.com/apache/commons-text/commit/70c080b146e8e6fb79cd97f780b65f863d4ec6d8


> TextStringBuilder append sub-sequence not consistent with Appendable
> --------------------------------------------------------------------
>
>                 Key: TEXT-138
>                 URL: https://issues.apache.org/jira/browse/TEXT-138
>             Project: Commons Text
>          Issue Type: Bug
>    Affects Versions: 1.4, 1.5, 1.6
>            Reporter: Neal Johnson
>            Priority: Minor
>              Labels: usability
>             Fix For: 1.7
>
>
> The method:
> {{append(final CharSequence seq, final int startIndex, final int length)}}
> Overrides the method defined by Appendable. However the behavior of the TextStringBuilder
implementation is not consistent with the definition in Appendable. As the class defines "that
some edge cases, with invalid indices or null input, have been altered - see individual methods"
this would not normally be an issue. However as the implementation states that it overrides
Appendable the class cannot be used as an Appendable as the last argument is expected to be
an end index and not a length.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message