commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEXT-138) TextStringBuilder append sub-sequence not consistant with Appendable
Date Sat, 03 Nov 2018 15:31:00 GMT

    [ https://issues.apache.org/jira/browse/TEXT-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674082#comment-16674082
] 

Gary Gregory commented on TEXT-138:
-----------------------------------

That sounds like a bug, the class says it implements the {{Appendable}} contract, so it should
be behave according to that contract.

> TextStringBuilder append sub-sequence not consistant with Appendable
> --------------------------------------------------------------------
>
>                 Key: TEXT-138
>                 URL: https://issues.apache.org/jira/browse/TEXT-138
>             Project: Commons Text
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Neal Johnson
>            Priority: Minor
>              Labels: usability
>
> The method:
> {{append(final CharSequence seq, final int startIndex, final int length)}}
> Overrides the method defined by Appendable. However the behavior of the TextStringBuilder
implementation is not consistent with the definition in Appendable. As the class defines "that
some edge cases, with invalid indices or null input, have been altered - see individual methods"
this would not normally be an issue. However as the implementation states that it overrides
Appendable the class cannot be used as an Appendable as the last argument is expected to be
an end index and not a length.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message