From issues-return-70408-archive-asf-public=cust-asf.ponee.io@commons.apache.org Thu Oct 25 15:45:36 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9938F180670 for ; Thu, 25 Oct 2018 15:45:35 +0200 (CEST) Received: (qmail 76441 invoked by uid 500); 25 Oct 2018 13:45:34 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 76430 invoked by uid 99); 25 Oct 2018 13:45:34 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Oct 2018 13:45:34 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 9B69CDFB32; Thu, 25 Oct 2018 13:45:33 +0000 (UTC) From: zmacomber To: issues@commons.apache.org Reply-To: issues@commons.apache.org References: In-Reply-To: Subject: [GitHub] commons-lang issue #358: ClassUtils.getBaseClasses(desiredBase, packageName) Content-Type: text/plain Message-Id: <20181025134533.9B69CDFB32@git1-us-west.apache.org> Date: Thu, 25 Oct 2018 13:45:33 +0000 (UTC) Github user zmacomber commented on the issue: https://github.com/apache/commons-lang/pull/358 > Should we overload `getBaseClasses` with the following: > > * `ClassUtils.getBaseClasses(final Class desiredBase, final String packageName, ClassLoader classLoader)` > * `ClassUtils.getBaseClasses(final Class desiredBase, final Package package)` > ? I have implemented this ---