commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Struberg (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (POOL-355) Add maxNumActive to pool config
Date Sun, 28 Oct 2018 11:16:00 GMT

    [ https://issues.apache.org/jira/browse/POOL-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666356#comment-16666356
] 

Mark Struberg edited comment on POOL-355 at 10/28/18 11:15 AM:
---------------------------------------------------------------

I like the code but I would rather make the {{int getMaxNumActive()}} method in the {{ObjectPool}}
interface a default method.
And this requires to bump our min requirement from 1.7 to Java8. Discussion is on the list.

Btw, it might be even better to use the existing {{getNumActive()}} and read it e.g. via mp-metrics
(see geronimo-metrics) or even a simple Servlet or JMX bean. That way you'd have the whole
graph over time and can also gain even more insight.
E.g. if the server takes 120 connections during startup and then idles around at 3 connections
you don't gain anything from the maxNumActive feature...


was (Author: struberg):
I like the code but I would rather make the {{int getMaxNumActive()}} method in the {{ObjectPool}}
interface a default method.
And this requires to bump our min requirement from 1.7 to Java8. Discussion is on the list.

> Add maxNumActive to pool config
> -------------------------------
>
>                 Key: POOL-355
>                 URL: https://issues.apache.org/jira/browse/POOL-355
>             Project: Commons Pool
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Benjamin Graf
>            Priority: Major
>
> To give a pool the "correct" size it is mandatory to know in which bounds pooled object
size is lying. Therefor a overall count of historical maximum of active objects sounds needed.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message