commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Don Jeba (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEXT-138) TextStringBuilder append sub-sequence not consistant with Appendable
Date Wed, 24 Oct 2018 16:42:00 GMT

    [ https://issues.apache.org/jira/browse/TEXT-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662513#comment-16662513
] 

Don Jeba commented on TEXT-138:
-------------------------------

i am planning to make a fix for this bug, i need some guidance on how to proceed. If i am
not wrong I cannot go ahead and make the necessary change in the existing function as its
not backward compactable. Can someone kindly advise on how i can proceed with the fix without
disturbing the current functionality (of considering the last parameter as length). Thank
you!

> TextStringBuilder append sub-sequence not consistant with Appendable
> --------------------------------------------------------------------
>
>                 Key: TEXT-138
>                 URL: https://issues.apache.org/jira/browse/TEXT-138
>             Project: Commons Text
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Neal Johnson
>            Priority: Minor
>              Labels: usability
>
> The method:
> {{append(final CharSequence seq, final int startIndex, final int length)}}
> Overrides the method defined by Appendable. However the behavior of the TextStringBuilder
implementation is not consistent with the definition in Appendable. As the class defines "that
some edge cases, with invalid indices or null input, have been altered - see individual methods"
this would not normally be an issue. However as the implementation states that it overrides
Appendable the class cannot be used as an Appendable as the last argument is expected to be
an end index and not a length.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message