commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IO-170) Scalable Iterator for files, better than FileUtils.iterateFiles
Date Tue, 16 Oct 2018 03:06:00 GMT

    [ https://issues.apache.org/jira/browse/IO-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651067#comment-16651067
] 

ASF GitHub Bot commented on IO-170:
-----------------------------------

GitHub user detinho opened a pull request:

    https://github.com/apache/commons-io/pull/67

    IO-170: Scalable Iterator for files, better than FileUtils.iterateFiles

    I took an aproach of implementing a separate class with the iterator logic.
    While this brings a little code duplication, it leads to a more scalable approach, as
the iterator class processes only the necessary files and directories to return the next file.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/detinho/commons-io IO-170

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-io/pull/67.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #67
    
----
commit 636d8a2da5344cede1d1588879b4476504004234
Author: detinho <marvinware2005@...>
Date:   2018-10-16T02:49:24Z

    IO-170: Scalable Iterator for files, better than FileUtils.iterateFiles

----


> Scalable Iterator for files, better than FileUtils.iterateFiles
> ---------------------------------------------------------------
>
>                 Key: IO-170
>                 URL: https://issues.apache.org/jira/browse/IO-170
>             Project: Commons IO
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 1.4
>         Environment: generic file systems
>            Reporter: Damian Noseda
>            Priority: Minor
>             Fix For: 3.x
>
>         Attachments: real_iterators.patch
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> Improve the way that iterateFiles generate an iterator. The current way it not scale.
It's try to add all files in a list and then return the iterator of that list. A better way
it would be create an customize Iterator<File> with a stack of arrays of File to go
up and down in the directory tree.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message