commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zmacomber <...@git.apache.org>
Subject [GitHub] commons-lang pull request #358: ClassUtils.getBaseClasses(desiredBase, packa...
Date Tue, 16 Oct 2018 12:01:52 GMT
Github user zmacomber commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/358#discussion_r225508801
  
    --- Diff: src/test/java/org/apache/commons/lang3/ClassUtilsTest.java ---
    @@ -1202,6 +1206,56 @@ public void testGetInnerClass() throws ClassNotFoundException {
             assertEquals( Inner.DeeplyNested.class, ClassUtils.getClass( "org.apache.commons.lang3.ClassUtilsTest$Inner.DeeplyNested"
) );
         }
     
    +    @Test
    +    public void testGetBaseClassesExtends() throws Exception {
    +        List<AnotherParent> classes = ClassUtils.getBaseClasses(AnotherParent.class,
"org.apache.commons.lang3.reflect.testbed");
    +        assertTrue(classes.size() > 0);
    +    }
    +
    +    @Test
    +    public void testGetBaseClassesAbstract() throws Exception {
    +        List<AbstractConcurrentInitializerTest> classes = ClassUtils.getBaseClasses(AbstractConcurrentInitializerTest.class,
"org.apache.commons.lang3.concurrent");
    +        assertTrue(classes.size() > 0);
    --- End diff --
    
    This is a good idea


---

Mime
View raw message