From issues-return-69916-archive-asf-public=cust-asf.ponee.io@commons.apache.org Fri Sep 28 00:17:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1C3FF180675 for ; Fri, 28 Sep 2018 00:17:02 +0200 (CEST) Received: (qmail 63846 invoked by uid 500); 27 Sep 2018 22:17:02 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 63827 invoked by uid 99); 27 Sep 2018 22:17:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Sep 2018 22:17:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CB044C1241 for ; Thu, 27 Sep 2018 22:17:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 3Q7yYku9gm5y for ; Thu, 27 Sep 2018 22:17:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0D94D5F3B7 for ; Thu, 27 Sep 2018 22:17:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 971A5E1013 for ; Thu, 27 Sep 2018 22:17:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 36FBB23F99 for ; Thu, 27 Sep 2018 22:17:00 +0000 (UTC) Date: Thu, 27 Sep 2018 22:17:00 +0000 (UTC) From: "Sebb (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CODEC-250) Wrong value calculated by Cologne Phonetic if a special character is placed between equal letters MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CODEC-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631105#comment-16631105 ] Sebb commented on CODEC-250: ---------------------------- In trying to simplify the code, I found what seems to be another way to fix the hyphenation issue. If the code detects 'H' or a char outside 'A' - 'Z' then ignore it completely. See patch to follow. > Wrong value calculated by Cologne Phonetic if a special character is placed between equal letters > ------------------------------------------------------------------------------------------------- > > Key: CODEC-250 > URL: https://issues.apache.org/jira/browse/CODEC-250 > Project: Commons Codec > Issue Type: Bug > Affects Versions: 1.5, 1.11 > Reporter: Alex Volodko > Priority: Major > Attachments: CODEC250.patch > > > The algorith for cologne phonetic is (simpilied): > # Encode letter by letter from left to right according to the conversion table. > # Remove all digits occurring more than once next to each other. > # Remove all code "0" except at the beginning. > Characters which are not specified in conversion table (such as hyphens) are ignored. See https://en.wikipedia.org/wiki/Cologne_phonetics > If the input is "test-test" the step results will be: > # 20822082 > # 2082082 > # 28282 > The expected result for "test-test" is therefor 28282. > The actual result for "test-test" is 282{color:#FF0000}2{color}82. > This bug is caused by the fix from > [https://github.com/apache/commons-codec/commit/72c8759a22c6552a2dfcdf61b29729f981752879] > and is present since 1.5 -- This message was sent by Atlassian JIRA (v7.6.3#76005)