From issues-return-69929-archive-asf-public=cust-asf.ponee.io@commons.apache.org Fri Sep 28 18:49:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B24D7180675 for ; Fri, 28 Sep 2018 18:49:03 +0200 (CEST) Received: (qmail 17719 invoked by uid 500); 28 Sep 2018 16:49:02 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 17708 invoked by uid 99); 28 Sep 2018 16:49:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Sep 2018 16:49:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 59DCCC549A for ; Fri, 28 Sep 2018 16:49:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 9HRYLqn56_vN for ; Fri, 28 Sep 2018 16:49:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3127F5F381 for ; Fri, 28 Sep 2018 16:49:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6AB3BE0112 for ; Fri, 28 Sep 2018 16:49:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3357823F9C for ; Fri, 28 Sep 2018 16:49:00 +0000 (UTC) Date: Fri, 28 Sep 2018 16:49:00 +0000 (UTC) From: "Rob Tompkins (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (TEXT-139) Improve JaccardSimilarity computational cost MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEXT-139?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Tompkins resolved TEXT-139. ------------------------------- Resolution: Fixed Thanks [~nickwong] > Improve JaccardSimilarity computational cost > -------------------------------------------- > > Key: TEXT-139 > URL: https://issues.apache.org/jira/browse/TEXT-139 > Project: Commons Text > Issue Type: Improvement > Reporter: nick wong > Priority: Major > Original Estimate: 24h > Remaining Estimate: 24h > > Improve JaccardSimilarity computational cost from O(n*m) to O(n+m). > I found two unnecessary loops in=C2=A0JaccardSimilarity.calculateJaccardS= imilarity() which can easy to be Improve. > I would make a PR soon. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)