From issues-return-69671-archive-asf-public=cust-asf.ponee.io@commons.apache.org Mon Sep 17 05:42:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 00268180652 for ; Mon, 17 Sep 2018 05:42:04 +0200 (CEST) Received: (qmail 58734 invoked by uid 500); 17 Sep 2018 03:42:03 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 58723 invoked by uid 99); 17 Sep 2018 03:42:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Sep 2018 03:42:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 80B03C0359 for ; Mon, 17 Sep 2018 03:42:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id BJ5CllZVudzc for ; Mon, 17 Sep 2018 03:42:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2664C5F437 for ; Mon, 17 Sep 2018 03:42:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5C542E092E for ; Mon, 17 Sep 2018 03:42:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0E9CB23F9C for ; Mon, 17 Sep 2018 03:42:00 +0000 (UTC) Date: Mon, 17 Sep 2018 03:42:00 +0000 (UTC) From: "Matt Juntunen (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEOMETRY-8) Update Exception Instantiation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GEOMETRY-8?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1661= 7048#comment-16617048 ]=20 Matt Juntunen commented on GEOMETRY-8: -------------------------------------- Here's a better, more concrete example of where at least some GeometryExcep= tion subclasses would be useful: a user loads a set of triangles from a 3D = model file and begins calculating surface normals and other attributes. If = an IllegalNormException is thrown during the calculation of the normal, the= n the triangle is degenerate and should be ignored. If some other type of G= eometryException is thrown in the processing, then something else has gone = wrong and the exception should be propagated to the caller. I see what you mean about keeping the public API minimal, though. I think a= good plan of action here is to hold off on this discussion until some of t= he other outstanding tasks are completed and then take stock of what except= ion types we have (since some may have been added) and what exactly we thin= k is actually needed. I've created GEOMETRY-16 for this purpose. In the mea= ntime, I'm going to mark this particular issue as closed. > Update Exception Instantiation > ------------------------------ > > Key: GEOMETRY-8 > URL: https://issues.apache.org/jira/browse/GEOMETRY-8 > Project: Apache Commons Geometry > Issue Type: Task > Reporter: Matt Juntunen > Priority: Major > > Update exception instantiation following the pattern in commons-numbers, = eg. custom private exception types created through factories. See the discu= ssion on GEOMETRY-2 and the GammaException class and its use in LogBeta in = commons-numbers.=C2=A0 > =C2=A0 > Based on discussion in GEOMETRY-9, we are going to implement our own exce= ption hierarchy for this component, eg GeometryException and subclasses. > =C2=A0 > Pull request: [https://github.com/apache/commons-geometry/pull/9] -- This message was sent by Atlassian JIRA (v7.6.3#76005)