commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CODEC-250) Wrong value calculated by Cologne Phonetic if a special character is placed between equal letters
Date Thu, 27 Sep 2018 11:43:00 GMT

    [ https://issues.apache.org/jira/browse/CODEC-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630262#comment-16630262
] 

Sebb commented on CODEC-250:
----------------------------

I find it confusing that the PREPROCESS_MAP contains a char that cannot occur.
(Thus there can never be 100% code coverage).

Before making any changes I think it would be useful to increase the test coverage.
For example, there don't appear to be any tests containing small sharp s.

> Wrong value calculated by Cologne Phonetic if a special character is placed between equal
letters
> -------------------------------------------------------------------------------------------------
>
>                 Key: CODEC-250
>                 URL: https://issues.apache.org/jira/browse/CODEC-250
>             Project: Commons Codec
>          Issue Type: Bug
>    Affects Versions: 1.5, 1.11
>            Reporter: Alex Volodko
>            Priority: Major
>
> The algorith for cologne phonetic is (simpilied):
>  # Encode letter by letter from left to right according to the conversion table.
>  # Remove all digits occurring more than once next to each other.
>  # Remove all code "0" except at the beginning.
> Characters which are not specified in conversion table (such as hyphens) are ignored.
See https://en.wikipedia.org/wiki/Cologne_phonetics
> If the input is "test-test" the step results will be:
>  # 20822082
>  # 2082082
>  # 28282
> The expected result for "test-test" is therefor 28282.
> The actual result for "test-test" is 282{color:#FF0000}2{color}82.
> This bug is caused by the fix from
> [https://github.com/apache/commons-codec/commit/72c8759a22c6552a2dfcdf61b29729f981752879]
> and is present since 1.5



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message