commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BCEL-296) Incorrect comment in several classes.
Date Thu, 13 Sep 2018 18:08:00 GMT

    [ https://issues.apache.org/jira/browse/BCEL-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613863#comment-16613863
] 

ASF GitHub Bot commented on BCEL-296:
-------------------------------------

Github user markro49 closed the pull request at:

    https://github.com/apache/commons-bcel/pull/16


> Incorrect comment in several classes.
> -------------------------------------
>
>                 Key: BCEL-296
>                 URL: https://issues.apache.org/jira/browse/BCEL-296
>             Project: Commons BCEL
>          Issue Type: Improvement
>            Reporter: Mark Roberts
>            Priority: Trivial
>             Fix For: 6.2
>
>
> There are 70 odd classes in the generic directory that have empty constructors with the
following comment:
>      * Empty constructor needed for the Class.newInstance() statement in
>      * Instruction.readInstruction(). Not to be used otherwise.
> Class.newInstance() is no longer called, the empty constructors are referenced directly.
 Perhaps the comment should just read:
>  * Empty constructor needed Instruction.readInstruction(). 
>  * Not to be used otherwise.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message