commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IMAGING-154) Remove Debug class
Date Thu, 16 Aug 2018 10:26:00 GMT

    [ https://issues.apache.org/jira/browse/IMAGING-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582327#comment-16582327
] 

ASF GitHub Bot commented on IMAGING-154:
----------------------------------------

Github user kinow commented on a diff in the pull request:

    https://github.com/apache/commons-imaging/pull/35#discussion_r210546814
  
    --- Diff: src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java ---
    @@ -327,7 +331,7 @@ private BmpImageContents readImageContents(final InputStream is,
             switch (bhi.compression) {
             case BI_RGB:
                 if (verbose) {
    --- End diff --
    
    Done in https://github.com/apache/commons-imaging/pull/35/commits/96b0a18e3c0ac435da85a3cf361975e2e77aa7f0
    
    Also removed the `PARAM_KEY_VERBOSE` constant, used to include a param in a map to enable
verbose. I initially put a `@deprecated` annotation, then realized this will be 1.0 of imaging,
not sanselan, so removing it should be OK.


> Remove Debug class
> ------------------
>
>                 Key: IMAGING-154
>                 URL: https://issues.apache.org/jira/browse/IMAGING-154
>             Project: Commons Imaging
>          Issue Type: Task
>    Affects Versions: Patch Needed
>            Reporter: Benedikt Ritter
>            Assignee: Bruno P. Kinoshita
>            Priority: Major
>             Fix For: 1.0
>
>
> Low level libraries should not do logging, but communicate through the use of exceptions
and meaningful return values. Remove the Debug class and  all it's uses.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message