From issues-return-68684-archive-asf-public=cust-asf.ponee.io@commons.apache.org Sat Jul 14 12:06:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4437A180676 for ; Sat, 14 Jul 2018 12:06:03 +0200 (CEST) Received: (qmail 37770 invoked by uid 500); 14 Jul 2018 10:06:02 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 37500 invoked by uid 99); 14 Jul 2018 10:06:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Jul 2018 10:06:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B36B0180414 for ; Sat, 14 Jul 2018 10:06:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id o3sqQfAacO3b for ; Sat, 14 Jul 2018 10:06:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D4CB25F300 for ; Sat, 14 Jul 2018 10:06:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7189BE0110 for ; Sat, 14 Jul 2018 10:06:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 33B7923F97 for ; Sat, 14 Jul 2018 10:06:00 +0000 (UTC) Date: Sat, 14 Jul 2018 10:06:00 +0000 (UTC) From: "Sebb (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LANG-1404) BooleanUtils.toBoolean(Integer) method added MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LANG-1404?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16544= 150#comment-16544150 ]=20 Sebb commented on LANG-1404: ---------------------------- LANG is for general purpose routines. I think what you need is a domain-specific method. It should check for 0, 1, null and return the appropriate bool. Any other value should fail as it implies a coding bug. This can then be documented with details of the convention that is being us= ed, and pointers to any existing documentation on the convention. > BooleanUtils.toBoolean(Integer) method added > -------------------------------------------- > > Key: LANG-1404 > URL: https://issues.apache.org/jira/browse/LANG-1404 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* > Reporter: Ruslan Sibgatullin > Priority: Minor > > Right now to convert an Integer=C2=A0to boolean there is either a null ch= eck needed: > {{final Integer value =3D 1;}} > {{if (value !=3D null) {}} > {{=C2=A0 =C2=A0 if(BooleanUtils.toBoolean(value)) {}} > {{=C2=A0 =C2=A0 =C2=A0 =C2=A0 // some code}} > =C2=A0 =C2=A0 =C2=A0 } > {{}}} > or two methods call: > =C2=A0 > {{final Integer value =3D 1;}} > {{final Boolean b =3D BooleanUtils.toBooleanObject(value);}} > {{if (BooleanUtils.toBoolean(b)) {}} > {{=C2=A0 =C2=A0 // some code}} > {{}}} > Some code-sugar is added with the help of method that accepts Integer and= returns boolean: > {{final Integer value =3D 1;}} > {{if (BooleanUtils.toBoolean(value)) {}} > =C2=A0 =C2=A0 =C2=A0 // some code > {{}}} > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)