commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1405) Remove checks for java versions below the minimum supported one
Date Fri, 27 Jul 2018 21:57:00 GMT

    [ https://issues.apache.org/jira/browse/LANG-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560383#comment-16560383
] 

ASF GitHub Bot commented on LANG-1405:
--------------------------------------

GitHub user larsgrefer opened a pull request:

    https://github.com/apache/commons-lang/pull/338

    LANG-1405 Remove check for Java 1.5

    Since the minimum Java version for commons-lang 3.x is 1.7, the check for Java 1.5 will
always be true

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/larsgrefer/commons-lang simplify-classUtils

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/338.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #338
    
----
commit 7d5a3984a893b3dd91a68cbe70211e2e58a6ff74
Author: Lars Grefer <github@...>
Date:   2018-07-27T21:36:23Z

    LANG-1405 Remove check for Java 1.5
    
    Since the minimum Java version for commons-lang 3.x is 1.7, the check for Java 1.5 will
always be true

----


> Remove checks for java versions below the minimum supported one
> ---------------------------------------------------------------
>
>                 Key: LANG-1405
>                 URL: https://issues.apache.org/jira/browse/LANG-1405
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>    Affects Versions: 3.5, 3.6, 3.7
>            Reporter: Lars Grefer
>            Priority: Minor
>             Fix For: 3.8
>
>
> The minimum java version for 3.x is java 1.7, so checks like {{SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_1_5)}}
will always be true and are therefore redundant



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message